fix: don't serialize undefined
as null
#7531
Merged
+145
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I added a special case for the serialization of
undefined
so thatserializeProps
doesn't serialize it asnull
.Closes #7528.
Testing
I expanded on the existing serialization tests and added a new case specifically for
undefined
.I also tested it in the example I provided for the issue by changing its
astro
dependency to theastro
package from this PR's branch.Docs
AFAIK the specific behavior of serialization is not documented, so no docs were added.
I decided to make the changeset a patch bump, but I'm not sure if it would be considered a breaking change instead.