Remove experimental flag for custom client directives #7237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d054718 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
|
This PR is blocked because it contains a |
sarah11918
approved these changes
May 29, 2023
natemoo-re
requested changes
May 31, 2023
|
Code looks great other than failing |
|
Yeah, the astro check tests has been flaky recently |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…withastro/astro into stable-custom-client-directives
bluwy
commented
Jun 5, 2023
| @@ -43,8 +43,6 @@ const ASTRO_CONFIG_DEFAULTS: AstroUserConfig & any = { | |||
| experimental: { | |||
| assets: false, | |||
| hybridOutput: false, | |||
| customClientDirectives: false, | |||
| middleware: false, | |||
There was a problem hiding this comment.
Looks like this wasn't removed in the unflag middleware PR, which I removed here.
natemoo-re
approved these changes
Jun 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
experimental.customClientDirectivesconfig (and its docs)RFC: withastro/roadmap#583
Testing
n/a. existing tests should pass.
Docs
Remove experimental reference: withastro/docs#3376