Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vite 4.2 #6759

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Upgrade to Vite 4.2 #6759

merged 5 commits into from
Apr 5, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 5, 2023

Changes

Upgrade to Vite 4.2 to use its newer options and remove some hacky code.

In Vite 4.2 exports the Rollup type as well, in future PRs we can migrate to this to prevent type mismatches between Rollup versions.

Testing

existing tests should pass

Docs

n/a. version bump.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

🦋 Changeset detected

Latest commit: 1216927

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 5, 2023
@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels Apr 5, 2023
@@ -148,6 +148,9 @@ async function ssrBuild(
logLevel: opts.viteConfig.logLevel ?? 'error',
build: {
target: 'esnext',
// Vite defaults cssMinify to false in SSR by default, but we want to minify it
// as the CSS generated are used and served to the client.
cssMinify: viteConfig.build?.minify == null ? true : !!viteConfig.build?.minify,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice! Glad to see this new option.

@bluwy bluwy merged commit 7116c02 into main Apr 5, 2023
@bluwy bluwy deleted the upgrade-vite-4.2 branch April 5, 2023 16:04
@astrobot-houston astrobot-houston mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants