Upgrade to Vite 4.2 #6759
Merged
Upgrade to Vite 4.2 #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1216927 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
github-actions
bot
added
pkg: svelte
matthewp
reviewed
Apr 5, 2023
| @@ -148,6 +148,9 @@ async function ssrBuild( | |||
| logLevel: opts.viteConfig.logLevel ?? 'error', | |||
| build: { | |||
| target: 'esnext', | |||
| // Vite defaults cssMinify to false in SSR by default, but we want to minify it | |||
| // as the CSS generated are used and served to the client. | |||
| cssMinify: viteConfig.build?.minify == null ? true : !!viteConfig.build?.minify, | |||
There was a problem hiding this comment.
Ah nice! Glad to see this new option.
matthewp
approved these changes
Apr 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Upgrade to Vite 4.2 to use its newer options and remove some hacky code.
In Vite 4.2 exports the
Rolluptype as well, in future PRs we can migrate to this to prevent type mismatches between Rollup versions.Testing
existing tests should pass
Docs
n/a. version bump.