-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better errors for when response is already sent #6719
Conversation
🦋 Changeset detectedLatest commit: ccd265f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2137e4d
to
57cc384
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs-approved error message! 🥳
ResponseSentError: { | ||
title: 'Unable to set response', | ||
code: 9004, | ||
message: 'The response has already been sent to the browser and cannot be altered.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful message. Docs is happy!
Changes
Astro.cookies.set()
andAstro.redirect()
on a response that has already been sent.Astro.redirect
behavior in SSR #6644Testing
Docs
N/A, error message