Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor esbuild setup to support watch #6608

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Refactor esbuild setup to support watch #6608

merged 1 commit into from
Mar 20, 2023

Conversation

natemoo-re
Copy link
Member

Changes

  • Version 0.17.0 of esbuild had some breaking changes.
  • This updates our astro-scripts package to take advantage of esbuild's new APIs
  • Fixes pnpm --filter astro run dev

Testing

Works locally, wasn't before

Docs

No, internal change only

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023

⚠️ No Changeset found

Latest commit: 2fd28f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You better watch out, you better ! cry, you better not error I'm telling you why: esbuild is watching... in deeeeev 🎵

@bholmesdev bholmesdev merged commit c9ad4a6 into main Mar 20, 2023
@bholmesdev bholmesdev deleted the fix/astro-scripts branch March 20, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants