Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in empty markdown files with content #6572

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Conversation

MoustaphaDev
Copy link
Member

Changes

When the markdown page is empty, rawFrontmatter is undefined which causes rawFrontmatter.indexOf to throw
image-raw-fm

The fix is to return early when the frontmatter is falsy.

Testing

Check that we get a correct error

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

🦋 Changeset detected

Latest commit: c86e4af

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 16, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great fix!

@natemoo-re natemoo-re merged commit fa132e3 into main Mar 17, 2023
@natemoo-re natemoo-re deleted the fix-cc-err-empty-md branch March 17, 2023 16:38
@astrobot-houston astrobot-houston mentioned this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants