Fix prerendered 404 page handling in SSR #6558
Merged
+86
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3033779 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #6511
When falling back to
404.astro, and that404.astrois prerendered, skip rendering it in SSR to prevent runtime errors. Instead, respond with a code 404 so that the environment can fallback and use the prerendered404.html.Testing
I've added a test to capture the first part. But I've not confirmed if environments do fallback to the
404.htmlif we return a 404 status code.But in a way, if a person opt to prerendering
404.html, it probably means that the deployed environment supports falling back to it.Docs
Perhaps we can document which environments support falling back to
404.html. It might be good to get the community to fill in this information as I find it rarely documented (especially paired with functions/workers), so it needs some trial and error.