fix(images): Fix empty frontmatter keys crashing Astro #6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2000ce0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
natemoo-re
approved these changes
Mar 9, 2023
bholmesdev
approved these changes
Mar 9, 2023
| @@ -46,7 +46,7 @@ export const msg = { | |||
| export function extractFrontmatterAssets(data: Record<string, any>): string[] { | |||
| function findAssets(potentialAssets: Record<string, any>): ImageMetadata[] { | |||
| return Object.values(potentialAssets).reduce((acc, curr) => { | |||
| if (typeof curr === 'object') { | |||
| if (typeof curr === 'object' && !Array.isArray(curr) && curr !== null) { | |||
There was a problem hiding this comment.
Gotta love checking if things are really actually truly objects huh 😓
|
Superseded by #6483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This would've never had happened in Rust
Fix #6469
Testing
Added one. That fixture gets built, so the build will fail if we don't handle this correctly. We could test in the dev server too presumably, but it's the same codepath either ways...
Docs
N/A