Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rebase _routes.json for Cloudflare when config.base set #6473

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

RichiCoder1
Copy link
Contributor

Changes

Fixes and issue where base was not being respected for the generation of _routes.json.

Part of #6471

Testing

Manual validation

Docs

Shouldn't need a doc fix as this fixes the _routes to align with expectations.

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

🦋 Changeset detected

Latest commit: c15b668

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 9, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the patch, thank you!

Fixes and issue where `base` was not being respected for the generation of `_routes.json`.
@bluwy bluwy merged commit 1c3e8f6 into withastro:main Mar 13, 2023
@RichiCoder1 RichiCoder1 deleted the patch-1 branch March 13, 2023 14:59
@astrobot-houston astrobot-houston mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants