Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve spaces from the template's package.json #6357

Closed
wants to merge 7 commits into from
Closed

fix: preserve spaces from the template's package.json #6357

wants to merge 7 commits into from

Conversation

rishi-raj-jain
Copy link
Contributor

fixes #6338

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 89a4af3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Feb 24, 2023
natemoo-re
natemoo-re reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm going to simplify the logic a bit with Regex, but we really appreciate the quality of life improvement!

packages/create-astro/src/actions/template.ts Outdated Show resolved Hide resolved
packages/create-astro/src/actions/template.ts Outdated Show resolved Hide resolved
@natemoo-re natemoo-re requested a review from a team as a code owner February 27, 2023 15:41
@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: lit Related to Lit (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) feat: markdown Related to Markdown (scope) labels Feb 27, 2023
@natemoo-re
Copy link
Member

Hmm... tried to rebase this but something got screwed up. I'm going to close and open a new one with the basic change.

@natemoo-re natemoo-re closed this Feb 27, 2023
@natemoo-re natemoo-re mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re left review comments

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[create-astro] CLI doesn't respect original file's indentation.
6 participants
@rishi-raj-jain @natemoo-re @weakish @vickvasquez @bluwy @astrobot-houston