Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent hydration mismatches in Preact #6215

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Tested in the demo app. An automated test is not really possible as it takes CPU throttling to recreate.
Kapture.2023-02-10.at.14.42.27.mp4

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2023

🦋 Changeset detected

Latest commit: d22b7b0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) labels Feb 10, 2023
@developit
Copy link

LGTM!

@matthewp matthewp merged commit a7f1805 into main Feb 13, 2023
@matthewp matthewp deleted the preact-hydration-mismatch branch February 13, 2023 19:48
@astrobot-houston astrobot-houston mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate DOM elements with conditional rending in preact and using SSR
2 participants