Check vite.emptyOutDir before emptying dir #6153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 09301da The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
1 task
1 task
natemoo-re
requested changes
Feb 6, 2023
Co-authored-by: Nate Moore <[email protected]>
natemoo-re
approved these changes
Feb 6, 2023
|
Im not sure what i need to do here, if anything. Just let me know what I can do to get this merged into next patch. |
|
Thanks @torchsmith! Nothing to do, I'm just waiting for CI to pass and then will merge. Appreciate the fix! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds
vite.build.emptyOutDirfunctionalityNot sure how to use pnpm or changeset.
Testing
No tests. Not sure how to add a test. Not sure how to build astro and manually test locally etc.
Docs
No Docs needed because this fits into existing docs.
Vite config should work within Astro config already.