[Lit] add client:only functionality to Lit integration
#6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5782159 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
|
failures seems like a flakes. Here is the Run from the commit before "add changeset" https://github.com/withastro/astro/actions/runs/4080151290/jobs/7032330368 |
|
ping @matthewp LMK WYT about some of the choices made |
matthewp
reviewed
Feb 6, 2023
|
np, code looks good. Just a minor point about whether this is patch/minor for the integration. And yes the test is a flaky one, I'll rerun it. |
|
Tests pass, feelsgoodman 😌 |
matthewp
approved these changes
Feb 7, 2023
|
Looks great, thanks! Will likely be released tomorrow. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
(note: I formatted
integrations/lit/src/client.tsso the diff is uggo. Try?w=1@astrojs/litto probable renderers listclient:onlyslot="..."to slotted HTML stringsTesting
I added the widely-used client:only test to the lit e2e tests and added slot & shadow dom-specific tests.
Docs
Add Lit to the
client:onlydocs/cc @withastro/maintainers-docs for feedback!