Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failed to execute 'encode' on 'TextEncoder': parameter 1 is not of type 'String' in Edge Runtime SSR #6070

Merged
merged 3 commits into from
Feb 1, 2023
Merged

fix: Failed to execute 'encode' on 'TextEncoder': parameter 1 is not of type 'String' in Edge Runtime SSR #6070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb6f9dd
minor fixes for errors related to vercel SSR in core
Jan 31, 2023
9736aa2
Merge branch 'main' into main
AirBorne04 Feb 1, 2023
e306ded
yielding empty string instead of nothing, to not exit the iterator
Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/curvy-owls-grow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'astro': patch
---

* safe guard against TextEncode.encode(HTMLString) [errors on vercel edge]
* safe guard against html.replace when html is undefined
4 changes: 3 additions & 1 deletion packages/astro/src/runtime/server/render/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,7 @@ export function chunkToByteArray(
if (chunk instanceof Uint8Array) {
return chunk as Uint8Array;
}
return encoder.encode(stringifyChunk(result, chunk));
// stringify chunk might return a HTMLString
let stringified = stringifyChunk(result, chunk);
return encoder.encode(stringified.toString());
}
6 changes: 4 additions & 2 deletions packages/astro/src/runtime/server/render/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,11 @@ If you're still stuck, please open an issue on GitHub or join us at https://astr

if (isPage || renderer?.name === 'astro:jsx') {
yield html;
} else {
} else if(html && html.length > 0) {
yield markHTMLString(html.replace(/\<\/?astro-slot\>/g, ''));
}
} else {
yield '';
}
})();
}

Expand Down