withastro · matthewp · Jan 9, 2023 · Jan 6, 2023 · Jan 6, 2023 · Jan 6, 2023
diff --git a/.changeset/curvy-beds-warn.md b/.changeset/curvy-beds-warn.md
@@ -0,0 +1,16 @@
+---
+'astro': major
+'@astrojs/prism': major
+'create-astro': major
+'@astrojs/mdx': minor
+'@astrojs/node': major
+'@astrojs/preact': major
+'@astrojs/react': major
+'@astrojs/solid-js': major
+'@astrojs/svelte': major
+'@astrojs/vercel': major
+'@astrojs/vue': major
+'@astrojs/telemetry': major
+---
+
+Remove support for Node 14. Minimum supported Node version is now >=16.12.0
diff --git a/.changeset/stupid-wolves-explain.md b/.changeset/stupid-wolves-explain.md
@@ -0,0 +1,7 @@
+---
+'@astrojs/webapi': major
+---
+
+Replace node-fetch's polyfill with undici.
+
+Since `undici` does not support it, this changes remove support for the `file:` protocol
diff --git a/packages/astro-prism/package.json b/packages/astro-prism/package.json
@@ -35,6 +35,6 @@
     "@types/prismjs": "1.26.0"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }
diff --git a/packages/astro/astro.js b/packages/astro/astro.js
@@ -50,7 +50,7 @@ async function main() {
 	// it's okay to hard-code the valid Node versions here since they will not change over time.
 	if (typeof require === 'undefined') {
 		console.error(`\nNode.js v${version} is not supported by Astro!
-Please upgrade to a version of Node.js with complete ESM support: "^14.18.0 || >=16.12.0"\n`);
+Please upgrade to a supported version of Node.js: ">=16.12.0"\n`);
 	}
 
 	// Not supported: Report the most helpful error message possible.

diff --git a/packages/astro/package.json b/packages/astro/package.json
@@ -198,7 +198,6 @@
     "eol": "^0.9.1",
     "memfs": "^3.4.7",
     "mocha": "^9.2.2",
-    "node-fetch": "^3.2.5",
     "node-mocks-http": "^1.11.0",
     "rehype-autolink-headings": "^6.1.1",
     "rehype-slug": "^5.0.1",
@@ -207,10 +206,11 @@
     "rollup": "^3.9.0",
     "sass": "^1.52.2",
     "srcset-parse": "^1.1.0",
+    "undici": "^5.14.0",
     "unified": "^10.1.2"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0",
+    "node": ">=16.12.0",
     "npm": ">=6.14.0"
   }
 }
diff --git a/packages/astro/src/runtime/server/response.ts b/packages/astro/src/runtime/server/response.ts
@@ -3,6 +3,21 @@ const isNodeJS =
 
 let StreamingCompatibleResponse: typeof Response | undefined;
 
+// Undici on Node 16 does not support simply iterating over a ReadableStream
+async function* streamAsyncIterator(stream: ReadableStream) {
+	const reader = stream.getReader();
+
+	try {
+		while (true) {
+			const { done, value } = await reader.read();
+			if (done) return;
+			yield value;
+		}
+	} finally {
+		reader.releaseLock();
+	}
+}
+
 function createResponseClass() {
 	StreamingCompatibleResponse = class extends Response {
 		#isStream: boolean;
@@ -21,9 +36,9 @@ function createResponseClass() {
 		async text(): Promise<string> {
 			if (this.#isStream && isNodeJS) {
 				let decoder = new TextDecoder();
-				let body = this.#body as AsyncIterable<Uint8Array>;
+				let body = this.#body;
 				let out = '';
-				for await (let chunk of body) {
+				for await (let chunk of streamAsyncIterator(body)) {
 					out += decoder.decode(chunk);
 				}
 				return out;
@@ -33,10 +48,10 @@ function createResponseClass() {
 
 		async arrayBuffer(): Promise<ArrayBuffer> {
 			if (this.#isStream && isNodeJS) {
-				let body = this.#body as AsyncIterable<Uint8Array>;
+				let body = this.#body;
 				let chunks: Uint8Array[] = [];
 				let len = 0;
-				for await (let chunk of body) {
+				for await (let chunk of streamAsyncIterator(body)) {
 					chunks.push(chunk);
 					len += chunk.length;
 				}

diff --git a/packages/astro/test/ssr-api-route.test.js b/packages/astro/test/ssr-api-route.test.js
@@ -1,7 +1,7 @@
 import { expect } from 'chai';
-import { loadFixture } from './test-utils.js';
+import { File, FormData } from 'undici';
 import testAdapter from './test-adapter.js';
-import { FormData, File } from 'node-fetch';
+import { loadFixture } from './test-utils.js';
 
 describe('API routes in SSR', () => {
 	/** @type {import('./test-utils').Fixture} */

diff --git a/packages/astro/test/test-utils.js b/packages/astro/test/test-utils.js
@@ -19,7 +19,7 @@ polyfill(globalThis, {
 });
 
 /**
- * @typedef {import('node-fetch').Response} Response
+ * @typedef {import('undici').Response} Response
  * @typedef {import('../src/core/dev/dev').DedvServer} DevServer
  * @typedef {import('../src/@types/astro').AstroConfig} AstroConfig
  * @typedef {import('../src/core/preview/index').PreviewServer} PreviewServer

diff --git a/packages/create-astro/package.json b/packages/create-astro/package.json
@@ -54,6 +54,6 @@
     "uvu": "^0.5.3"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }
diff --git a/packages/integrations/mdx/package.json b/packages/integrations/mdx/package.json
@@ -71,6 +71,6 @@
     "vite": "^4.0.3"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }
diff --git a/packages/integrations/node/package.json b/packages/integrations/node/package.json
@@ -37,12 +37,12 @@
     "astro": "^2.0.0-beta.0"
   },
   "devDependencies": {
-    "@types/node-fetch": "^2.6.2",
     "@types/send": "^0.17.1",
     "astro": "workspace:*",
     "astro-scripts": "workspace:*",
     "chai": "^4.3.6",
     "mocha": "^9.2.2",
-    "node-mocks-http": "^1.11.0"
+    "node-mocks-http": "^1.11.0",
+    "undici": "^5.14.0"
   }
 }
diff --git a/packages/integrations/node/src/response-iterator.ts b/packages/integrations/node/src/response-iterator.ts
@@ -4,7 +4,7 @@
  *  - https://github.com/apollographql/apollo-client/blob/main/src/utilities/common/responseIterator.ts
  */
 
-import type { Response as NodeResponse } from 'node-fetch';
+import type { Response as NodeResponse } from 'undici';
 import { Readable as NodeReadableStream } from 'stream';
 
 interface NodeStreamIterator<T> {

diff --git a/packages/integrations/preact/package.json b/packages/integrations/preact/package.json
@@ -47,6 +47,6 @@
     "preact": "^10.6.5"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }
diff --git a/packages/integrations/react/package.json b/packages/integrations/react/package.json
@@ -52,6 +52,6 @@
     "@types/react-dom": "^17.0.17 || ^18.0.6"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }
diff --git a/packages/integrations/solid/package.json b/packages/integrations/solid/package.json
@@ -44,6 +44,6 @@
     "solid-js": "^1.4.3"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }
diff --git a/packages/integrations/svelte/package.json b/packages/integrations/svelte/package.json
@@ -46,6 +46,6 @@
     "svelte": "^3.54.0"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }
diff --git a/packages/integrations/vercel/src/serverless/entrypoint.ts b/packages/integrations/vercel/src/serverless/entrypoint.ts
@@ -3,21 +3,12 @@ import type { SSRManifest } from 'astro';
 import { App } from 'astro/app';
 import type { IncomingMessage, ServerResponse } from 'node:http';
 
-import * as requestTransformLegacy from './request-transform/legacy.js';
-import * as requestTransformNode18 from './request-transform/node18.js';
+import { getRequest, setResponse } from './request-transform';
 
 polyfill(globalThis, {
 	exclude: 'window document',
 });
 
-// Node 18+ has a new API for request/response, while older versions use node-fetch
-// When we drop support for Node 14, we can remove the legacy code by switching to undici
-
-const nodeVersion = parseInt(process.version.split('.')[0].slice(1)); // 'v14.17.0' -> 14
-
-const { getRequest, setResponse } =
-	nodeVersion >= 18 ? requestTransformNode18 : requestTransformLegacy;
-
 export const createExports = (manifest: SSRManifest) => {
 	const app = new App(manifest);
 

diff --git a/...rc/serverless/request-transform/node18.ts → ...ercel/src/serverless/request-transform.ts b/...rc/serverless/request-transform/node18.ts → ...ercel/src/serverless/request-transform.ts
diff --git a/packages/integrations/vercel/src/serverless/request-transform/legacy.ts b/packages/integrations/vercel/src/serverless/request-transform/legacy.ts
diff --git a/packages/integrations/vue/package.json b/packages/integrations/vue/package.json
@@ -53,6 +53,6 @@
     "vue": "^3.2.30"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }
diff --git a/packages/telemetry/package.json b/packages/telemetry/package.json
@@ -32,7 +32,7 @@
     "dset": "^3.1.2",
     "is-docker": "^3.0.0",
     "is-wsl": "^2.2.0",
-    "node-fetch": "^3.2.5",
+    "undici": "^5.14.0",
     "which-pm-runs": "^1.1.0"
   },
   "devDependencies": {
@@ -45,6 +45,6 @@
     "mocha": "^9.2.2"
   },
   "engines": {
-    "node": "^14.18.0 || >=16.12.0"
+    "node": ">=16.12.0"
   }
 }
diff --git a/packages/telemetry/src/post.ts b/packages/telemetry/src/post.ts
@@ -1,4 +1,4 @@
-import fetch from 'node-fetch';
+import { fetch } from 'undici';
 
 const ASTRO_TELEMETRY_ENDPOINT = `https://telemetry.astro.build/api/v1/record`;
 

diff --git a/packages/webapi/LICENSE b/packages/webapi/LICENSE
@@ -32,6 +32,4 @@ Code from [fetch-blob](https://www.npmjs.com/package/fetch-blob) is licensed und
 
 Code from [formdata-polyfill](https://www.npmjs.com/package/formdata-polyfill) is licensed under the MIT License (MIT), Copyright Jimmy Wärting.
 
-Code from [node-fetch](https://www.npmjs.com/package/node-fetch) is licensed under the MIT License (MIT), Copyright Node Fetch Team.
-
 Code from [web-streams-polyfill](https://www.npmjs.com/package/web-streams-polyfill) is licensed under the MIT License (MIT), Copyright Mattias Buelens and Diwank Singh Tomer.
diff --git a/packages/webapi/README.md b/packages/webapi/README.md
@@ -174,6 +174,4 @@ Code from [fetch-blob](https://www.npmjs.com/package/fetch-blob) is licensed und
 
 Code from [formdata-polyfill](https://www.npmjs.com/package/formdata-polyfill) is licensed under the MIT License (MIT), Copyright Jimmy Wärting.
 
-Code from [node-fetch](https://www.npmjs.com/package/node-fetch) is licensed under the MIT License (MIT), Copyright Node Fetch Team.
-
 Code from [web-streams-polyfill](https://www.npmjs.com/package/web-streams-polyfill) is licensed under the MIT License (MIT), Copyright Mattias Buelens and Diwank Singh Tomer.
diff --git a/packages/webapi/package.json b/packages/webapi/package.json
@@ -51,7 +51,7 @@
   "homepage": "https://github.com/withastro/astro/tree/main/packages/webapi#readme",
   "dependencies": {
     "global-agent": "^3.0.0",
-    "node-fetch": "^3.2.5"
+    "undici": "^5.14.0"
   },
   "devDependencies": {
     "@rollup/plugin-alias": "^3.1.9",