Cleanup internal breaking changes #5724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 76f163b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
commented
Jan 3, 2023
| let firstArg = code.slice(firstArgStart, firstArgEnd); | ||
| // If argument is template literal, try convert to a normal string. | ||
| // This is needed for compat with previous recast strategy. | ||
| // TODO: Remove in Astro 2.0 | ||
| if (firstArg.startsWith('`') && firstArg.endsWith('`') && !firstArg.includes('${')) { | ||
| firstArg = JSON.stringify(firstArg.slice(1, -1)); | ||
| } | ||
| const firstArg = code.slice(firstArgStart, firstArgEnd); |
There was a problem hiding this comment.
The intent here was to remove support for:
Astro.glob(`./foo/*.md`) // using template literalswhich transforms to import.meta.glob, but it looks like Vite 4 now supports template literal too so this is no longer a breaking change to note in the changeset.
matthewp
approved these changes
Jan 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
toStringsupport forRenderTemplateResult.Astro.globwith template strings usageTesting
Existing test should passed.
Docs
I'm sending a docs PR to remove https://docs.astro.build/en/guides/typescript/#vue-components-are-mistakenly-typed-by-the-typesreact-package-when-installed as it's fixed in Volar.
withastro/docs#2276