Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with loading .ts in .mjs config #5431

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Test added
  • Had to clean up the mock fs fallback plugin a bit.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

🦋 Changeset detected

Latest commit: 8e652dc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 17, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the try catch 🙈

@matthewp matthewp merged commit 1ab5058 into main Nov 17, 2022
@matthewp matthewp deleted the import-ts-from-mjs branch November 17, 2022 15:33
This was referenced Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to import TypeScript integration since Astro 1.6.9
2 participants