Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error if failed to fetch remote image #5393

Merged
merged 8 commits into from
Nov 16, 2022

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Nov 14, 2022

Changes

I can't catch an error in the loadRemoteImage function when the fetch function occurs error

fix #5392

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2022

🦋 Changeset detected

Latest commit: ec72224

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Nov 14, 2022
@JerryWu1234 JerryWu1234 changed the title I can't catch an error in the loadRemoteImage function when the fetch function occurs error Log error if failed to fetch remote image Nov 15, 2022
@matthewp matthewp merged commit e2fb0c4 into withastro:main Nov 16, 2022
This was referenced Nov 16, 2022
@JerryWu1234 JerryWu1234 deleted the fix_message branch December 6, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can't catch an error in the loadRemoteImage function when the fetch function occurs error
4 participants