Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spread parameters for server endpoints #5106

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 17, 2022

Changes

Fix #3671

Support [...slug].json.ts. [...slug].ts already works, but the .json was tripping the path matcher.

I've marked this as a patch as this was supposed to work, but it could also be a minor.

Testing

Added routing-priority tests

Docs

N/A. Routing logic has been explained in https://docs.astro.build/en/core-concepts/routing/ so they should apply here too.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

🦋 Changeset detected

Latest commit: ea477bc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 17, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a patch!

@bluwy bluwy merged commit ef0c543 into main Oct 18, 2022
@bluwy bluwy deleted the fix-endpoint-catchall branch October 18, 2022 05:16
@astrobot-houston astrobot-houston mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Non-HTML pages with spread/rest parameter crashes dev server
2 participants