Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra slash when adding integrations that ends with /astro #4817

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Fix extra slash when adding integrations that ends with /astro #4817

merged 3 commits into from
Sep 20, 2022

Conversation

mhdcodes
Copy link
Contributor

Changes

This PR fixes a bug in toIdent funtion used by astro add to convert an arbitrary NPM package name into a JS identifier.
see #4808

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

🦋 Changeset detected

Latest commit: 5fc5be9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-cyclic Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch
@e2e/third-party-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mhdcodes mhdcodes changed the title Fix extra slash when installing packages that ends with /astro Fix extra slash when adding integrations that ends with /astro Sep 20, 2022
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 20, 2022
@mhdcodes
Copy link
Contributor Author

closes #4808

@matthewp
Copy link
Contributor

Thanks @mohammed-elhaouari can you add a changeset? Run pnpm changeset and go through the instructions. Thanks!

@mhdcodes
Copy link
Contributor Author

hey @matthewp I'm not sure though, that this fix will not introduce regressions.

@matthewp
Copy link
Contributor

Let's trusts the tests 🙏

@mhdcodes
Copy link
Contributor Author

@matthewp test are green. 🚀

@matthewp matthewp merged commit a49bc2f into withastro:main Sep 20, 2022
@mhdcodes mhdcodes deleted the fix/4808-parse-package-identifier branch September 20, 2022 16:36
@astrobot-houston astrobot-houston mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants