Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno example #4641

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Add Deno example #4641

merged 4 commits into from
Sep 20, 2022

Conversation

ElianCodes
Copy link
Member

Changes

  • Adds a Deno example based on the basics example.
  • Changes the preview command to deno run --allow-net --allow-read ./dist/server/entry.mjs
  • No changeset required

Testing

Tested locally, explained in https://www.elian.codes/blog/22-05-06-deploying-astro-on-deno/

Docs

The only change we might need to add to this example, is explain why the npm run preview command has changed to the native Deno CLI

@ElianCodes ElianCodes requested a review from a team as a code owner September 6, 2022 14:31
@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2022

⚠️ No Changeset found

Latest commit: 4f0cd3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Sep 6, 2022
@Jutanium
Copy link
Contributor

Jutanium commented Sep 6, 2022

From the docs perspective: I'm preparing an explanation for astro preview and why it doesn't work for server builds. This PR provides a great example for what a preview command should look like for SSR!

@ElianCodes
Copy link
Member Author

@Jutanium, If you need me to help anywhere on the docs, lemme know!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs is cool with README as long as one comment is addressed!

examples/deno/README.md Show resolved Hide resolved
@matthewp matthewp merged commit f2b515d into withastro:main Sep 20, 2022
@ElianCodes ElianCodes deleted the add-deno-example branch February 13, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants