-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@astrojs/image] support additional resize options #4438
Conversation
🦋 Changeset detectedLatest commit: 12150e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4378291
to
f10473b
Compare
@obennaci still marked as draft, is this ready? |
Should be good now 👍 |
7fd2a0f
to
14c5269
Compare
Thanks for opening this, @obennaci! Looks like I missed the #4341 issue while traveling last week 👀 We're actually still a little too early in the We're working on making I'm going to close this PR for now only because the integration needs a bit more time to bake to make sure the core API surface is the right basis for a 1.0 version of the integration. Hopefully we can pull this back up pretty soon though to revisit how to add more fine-grained transform controls here! |
Reopening this PR, we're further down the path towards the Squoosh migration now and I think we should be fine here to add more specific resize options 🥳 @obennaci if you don't mind, I'll get this branch caught up to main and prepped for a final review and merge PR #4642 came through today and shock loose the sharp vs. Squoosh concerns for me. The APIs are close enough that it won't be a problem to have a few specific checks where the Squoosh loader can just warn that a specific transform option is only supported in sharp |
Happy to hear that, can't wait 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to bring this one back now that we have a better idea of how it will work with Squoosh!
We'll need to add docs and test coverage before merging this in, happy to help answer any questions you have or pick the docs/testing work up on my end to get this across the finish line 👍
138b931
to
e72cb0c
Compare
e72cb0c
to
f64134d
Compare
On the docs side, it's worth defining the |
231464c
to
5849844
Compare
6c89924
to
c4d14e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, thanks for all the updates here! I'm just running a quick test locally against the astro.build project and then we'll merge this in ready for the next release 🎉
Changes
Add support for additional Sharp resize options;
fit
,position
,background
,,kernel
andwithoutReduction
.withoutEnlargement
Fixes #4341
Testing
Manually so far.
Docs