Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing newline bug in mdx #4145

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix missing newline bug in mdx #4145

merged 1 commit into from
Aug 5, 2022

Conversation

FredKSchott
Copy link
Member

Changes

  • Users reported needing a newline at the end of their files.
  • tracked it down to MDX needing two newlines between content and where we inject any exports.

Testing

  • Updated existing test to test for this.

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

🦋 Changeset detected

Latest commit: 5a57e79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@astrojs/mdx Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 4, 2022
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work tracking that down 🙌

Copy link

@paabloLC paabloLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this is good functionality, at least, save time =)

@paabloLC
Copy link

paabloLC commented Aug 4, 2022

LGTM! Nice work tracking that down 🙌

Super agree, I implemented this improvement a few days ago and it works nicely.

@aFuzzyBear
Copy link
Contributor

Really good catch Fred 👊

@FredKSchott FredKSchott merged commit c7efcf5 into main Aug 5, 2022
@FredKSchott FredKSchott deleted the mdx-newline-fix branch August 5, 2022 06:12
@astrobot-houston astrobot-houston mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants