-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Lit integration be compat with Vite 3.0.1 #4009
Conversation
🦋 Changeset detectedLatest commit: e7fc927 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lit's give ourselves a com-pat on the back 👏
packages/astro/package.json
Outdated
@@ -136,7 +136,7 @@ | |||
"strip-ansi": "^7.0.1", | |||
"supports-esm": "^1.0.0", | |||
"tsconfig-resolver": "^3.0.1", | |||
"vite": "^3.0.0", | |||
"vite": "^3.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider this Vite making breaking changes behind patches, and not following semver. Can we pin to v3.0.2 for now until their v3 matures a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for this. FWIW, we counted it as regression as we didn't intend to change the way noExternal/external
works. Given the current discussion in vitejs/vite#9275, I think that external will end up working as it did in Vite 2 and also count as a regression fix.
But I totally understand fixing the version until this is resolved 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM either way, but would prefer to pin to an exact version!
Changes
external
for non-main entrypoints in packages.Testing
Docs
N/A, bug fix.