Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small create-astro wording changes #3831

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

FredKSchott
Copy link
Member

Changes

  • Small updates as a followup to this
  • Provide more guidance to a new or beginner user

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2022

🦋 Changeset detected

Latest commit: 1007499

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Jul 5, 2022
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think it would still be nice to have more information before an action rather than after accepting/rejecting a prompt. “optional” & “recommended” are a little vague, but still better than before.

And yeah, we should definitely bring over Sarah’s excellent template descriptions although that can happen in a follow-up PR.

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! There's always more tweaking we can do here but I like the more friendly/conversational tone here 👍

@FredKSchott FredKSchott merged commit 4fb0850 into main Jul 7, 2022
@FredKSchott FredKSchott deleted the small-create-astro-fixes branch July 7, 2022 18:06
@astrobot-houston astrobot-houston mentioned this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants