Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: document sitemap + SSR use case #3689

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Jun 23, 2022

Changes

Testing

N/A

Docs

See README updates!

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2022

🦋 Changeset detected

Latest commit: 24f9b7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/sitemap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 23, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, LGTM!

@bholmesdev bholmesdev merged commit 3f8ee70 into main Jun 23, 2022
@bholmesdev bholmesdev deleted the fix/sitemap-ssr-improvements branch June 23, 2022 15:31
@github-actions github-actions bot mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Sitemap generation does not work with SSR
2 participants