Fix: --host flag logs when no network IPs are found
#3547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 93b94dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bholmesdev
changed the title
--host flag logs when no network IPs are found
matthewp
reviewed
Jun 7, 2022
| if (networkLogging === 'host-to-expose') { | ||
| network = `${networkPrefix}${dim('use --host to expose')}`; | ||
| } else if (networkLogging === 'visible') { | ||
| const ipv4Networks = Object.values(os.networkInterfaces()) |
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* feat: add fallback log if no network interfaces found * fix: extra newline on missing network log * chore: changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
unable to find network to exposemessage when no network IPs are foundTesting
None added, since testing would require stubbing Node's
ospackage to return an empty array. I attempted to use Sinon for this, and discovered it can't support ESM 😢 Would love to improve our testing infra for cases like this!Docs
N/A