Consolidate inline hydration scripts into one #3244
Merged
+152
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 71f3694 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
bholmesdev
reviewed
Apr 30, 2022
bholmesdev
reviewed
May 2, 2022
bholmesdev
reviewed
May 2, 2022
bholmesdev
reviewed
May 2, 2022
Merged
matthewp
added a commit
that referenced
this pull request
May 3, 2022
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Consolidate inline hydration scripts into one * Adds changeset * Update custom element test * Provide a better name for tracking if we have added a hydration script
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
…" (withastro#3275) * Revert "Consolidate inline hydration scripts into one (withastro#3244)" This reverts commit 48a35e6. * Fix types * Adds changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astroIdmostly goes away with this method. It's still needed for HMR, but this should close out issues related to the astroId not matching.Testing
Docs
N/A, implementation detail.