-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: [create astro] replace component selector with "astro add" #3223
Merged
bholmesdev
merged 13 commits into
main
from
feat/create-astro-remove-component-selector
Apr 28, 2022
Merged
Feat: [create astro] replace component selector with "astro add" #3223
bholmesdev
merged 13 commits into
main
from
feat/create-astro-remove-component-selector
Apr 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5102f43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: create-astro
Related to the `create-astro` package (scope)
test
labels
Apr 27, 2022
JuanM04
reviewed
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing PR! Left some comments
bholmesdev
force-pushed
the
feat/create-astro-remove-component-selector
branch
from
April 27, 2022 21:03
18c8dd7
to
5102f43
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astro add
with binary directory set onexeca
if user has installed dependenciesnpx astro@latest add
(orpnpx
if user ran withpnpm
) when user has NOT installed dependenciesstarter
andminimal
options with a single "Just the basics" optionTesting
Add
astro-add-step.test.js
- asserts we usenpx
when user has not installed dependencies, and vice versa.Docs
N/A