Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: [create astro] replace component selector with "astro add" #3223

Merged
merged 13 commits into from
Apr 28, 2022

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Remove "what component framework" step
  • Add new "run astro add" step
    • Uses astro add with binary directory set on execa if user has installed dependencies
    • Uses npx astro@latest add (or pnpx if user ran with pnpm) when user has NOT installed dependencies
    • Includes log: "You can always run "npx astro add" later!" If user responds with "no."
  • Replace starter and minimal options with a single "Just the basics" option

Testing

Add astro-add-step.test.js - asserts we use npx when user has not installed dependencies, and vice versa.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2022

🦋 Changeset detected

Latest commit: 5102f43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: create-astro Related to the `create-astro` package (scope) test labels Apr 27, 2022
Copy link
Contributor

@JuanM04 JuanM04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR! Left some comments

packages/create-astro/src/index.ts Outdated Show resolved Hide resolved
@bholmesdev bholmesdev force-pushed the feat/create-astro-remove-component-selector branch from 18c8dd7 to 5102f43 Compare April 27, 2022 21:03
@bholmesdev bholmesdev merged commit b7cd695 into main Apr 28, 2022
@bholmesdev bholmesdev deleted the feat/create-astro-remove-component-selector branch April 28, 2022 00:58
@github-actions github-actions bot mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants