Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svelte version in renderer-svelte #2300

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

moritzlaube
Copy link
Contributor

I am having funny console logs saying that my svelte component received an unexpected slot "default".. This issue is described here.

Changes

Supposedly, updating svelte to version 3.44.3 solves this issue.

Testing

Sorry, I was unable to fork the renderer and test it locally.

Docs

bug fix only

I am having funny console logs saying that my svelte component `received an unexpected slot "default".`. This issue is described here: sveltejs/kit#981

Supposedly, updating svelte to version 3.44.3 solves this issue. I couldn't test it, though.
@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2022

🦋 Changeset detected

Latest commit: 6b5318b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/renderer-svelte Patch
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) labels Jan 3, 2022
@matthewp
Copy link
Contributor

matthewp commented Jan 4, 2022

Sounds good, can you add a changeset with yarn changeset? This is necessary to get the fix released.

@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: 6b5318b

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61d45e399f19e400086f87c8

😎 Browse the preview: https://deploy-preview-2300--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Jan 4, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 6b5318b

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61d45e39cc5aa100083df98c

😎 Browse the preview: https://deploy-preview-2300--astro-docs-2.netlify.app

@matthewp matthewp merged commit 3448667 into withastro:main Jan 4, 2022
@github-actions github-actions bot mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants