fix(i18n): manual routing with rewrite #12718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 13e31b7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
force-pushed
the
fix/i18n-middleware
branch
2 times, most recently
from
00100f2 to
fc669f3
Compare
ematipico
force-pushed
the
fix/i18n-middleware
branch
from
fc669f3 to
13e31b7
Compare
ematipico
commented
Dec 11, 2024
Comment on lines
+304
to
+305
| response?.headers.get(REROUTE_DIRECTIVE_HEADER) === 'no' && | ||
| typeof fallback === 'undefined' |
There was a problem hiding this comment.
Even though we're about to render the internal 404 or 500, we still want to handle the fallback
CodSpeed Performance ReportMerging #12718 will not alter performanceComparing Summary
|
ascorbic
approved these changes
Dec 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #12431
The
fallbackobject was always undefined. Not sure how overlooked that!Testing
Added a new test
Docs
N/A