Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update sitemap tests to use the latest @astrojs/node #12593

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

ematipico
Copy link
Member

Changes

The sitemap tests are currently failing because it uses an outdated version of @astrojs/node.

This PR updates it

Testing

CI should pass

Docs

N/A

Copy link

changeset-bot bot commented Dec 3, 2024

⚠️ No Changeset found

Latest commit: bcca2d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Dec 3, 2024
@@ -38,7 +38,7 @@
"zod": "^3.23.8"
},
"devDependencies": {
"@astrojs/node": "^1.0.0",
"@astrojs/node": "^9.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing that wouldn't happen with the adapters in the monorepo 😔

@ematipico ematipico merged commit 2453cac into main Dec 3, 2024
15 checks passed
@ematipico ematipico deleted the chore/fix-tests branch December 3, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants