Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better images changeset pt 2 #12484

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore: better images changeset pt 2 #12484

merged 1 commit into from
Nov 20, 2024

Conversation

ascorbic
Copy link
Contributor

Changes

I merged the previous PR before Sarah gave her review. These changes are based on her feedback, and on seeing some formatting errors in the release PR

Testing

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: fb28a9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Nov 20, 2024
github-actions[bot]
github-actions bot requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@ascorbic ascorbic requested a review from sarah11918 November 20, 2024 13:42
sarah11918
sarah11918 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ascorbic ascorbic merged commit 18a04c0 into next Nov 20, 2024
2 checks passed
@ascorbic ascorbic deleted the images-changeset-fix branch November 20, 2024 13:51
@ascorbic ascorbic restored the images-changeset-fix branch November 22, 2024 09:59
@ascorbic ascorbic deleted the images-changeset-fix branch November 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @sarah11918