Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content layer glob deletion #12476

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Nov 19, 2024

Changes

Testing

Adds a test case

Docs

N/A bugfix

Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 16741b2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 19, 2024
Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #12476 will degrade performances by 11.96%

Comparing fix/content-layer-glob-delete (16741b2) with main (733d6c1)

Summary

❌ 1 regressions
✅ 5 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/content-layer-glob-delete Change
Rendering: streaming [true], .mdx file 1 s 1.2 s -11.96%

@florian-lefebvre florian-lefebvre marked this pull request as ready for review November 19, 2024 15:08
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted

@florian-lefebvre florian-lefebvre merged commit 80a9a52 into main Nov 19, 2024
14 of 15 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/content-layer-glob-delete branch November 19, 2024 15:56
This was referenced Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still getting deleted collection entries from getCollection function
2 participants