feat(examples): New basics template #12472
Open
+225
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: example
Princesseuh
commented
Nov 18, 2024
|
Princesseuh
commented
Nov 18, 2024
| @@ -4,5 +4,3 @@ | |||
| export { default as Code } from './Code.astro'; | |||
| // @ts-ignore | |||
| export { default as Debug } from './Debug.astro'; | |||
| // @ts-ignore | |||
| export { default as Welcome } from './Welcome.astro'; | |||
There was a problem hiding this comment.
It moved it back into the template for multiple reasons:
- You can't import from
astro:componentsa component that has styles defined the "Astro way", you cause styles to leak everywhere - Inside Astro, you could check out the code, but not modify it, which feels like pedagogically it was a downgrade
There was a problem hiding this comment.
FWIW (and perhaps you already know) for no1, I think is:inline can be used to avoid that, unless I miss something that requires processing the styles.
delucis
reviewed
Nov 20, 2024
delucis
reviewed
Nov 20, 2024
ematipico
approved these changes
Nov 20, 2024
matthewp
approved these changes
Nov 20, 2024
delucis
requested changes
Nov 20, 2024
bluwy
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This updates the design of the basics template for Astro 5. It aims to provide a mix between the old basics and minimal templates, so that it's easy for someone to take the basics, remove a few things easily and get minimal.
Looks like this
Testing
Tested manually
Docs
N/A. Docs doesn't seem to describe this template as far as I can tell.