Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): match against decoded pathname #12270

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Oct 21, 2024

Changes

Closes PLT-2596
Closes #12262

The pathname coming from the server is usually encoded, so we need to decode it when computing the parameters.

Testing

Added a new test case

Docs

N/A

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 69736df

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 21, 2024
@ematipico ematipico marked this pull request as ready for review October 21, 2024 11:15
@ematipico ematipico marked this pull request as draft October 21, 2024 11:16
@ematipico ematipico force-pushed the fix/routing-encoding branch from 5881c59 to da7866a Compare October 21, 2024 15:03
@ematipico ematipico force-pushed the fix/routing-encoding branch from da7866a to 69736df Compare October 21, 2024 15:04
@ematipico ematipico marked this pull request as ready for review October 21, 2024 15:05
@ematipico ematipico merged commit 25192a0 into next Oct 30, 2024
13 checks passed
@ematipico ematipico deleted the fix/routing-encoding branch October 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant