fix(container): emit components as partials #12239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e796f9f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Princesseuh
reviewed
Oct 16, 2024
.changeset/soft-rabbits-draw.md
Outdated
|
|
||
| Until now, the Container API was rendering the components as they were full-fledged Astro pages. | ||
|
|
||
| Full-fledged Astro pages contain `<!DOCTYPE html>` but default. This was not intended, and this patch fixes the behavior. |
There was a problem hiding this comment.
My take is still that we shouldn't be adding the doctype for people 😠
Princesseuh
approved these changes
Oct 16, 2024
sarah11918
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Just some suggestions for your consideration, @ematipico ! 🙌
Co-authored-by: Sarah Rainsberger <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The container API was rendering components as full-fledged pages, which was a bug.
This PR ships a breaking change to the rendered default behaviour of the container API. Now, the components are rendered as partials by default, and users can tweak the behaviour by passing
partial: falseas a new optionTesting
Added new assertions a new test case
Docs
withastro/docs#9696