Unset charset=utf-8 content-type for md/mdx pages #12231
Conversation
🦋 Changeset detectedLatest commit: 6348b48 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I personally think that users should provide the tag themselves. However, Astro is the content framework, so the framework should help users display any type of content, even when it isn't If our head propagation is solid, the I am in favour of |
For markdown or MDX pages without any layout, we actually send the generated HTML as is. So a If the user were to add the Anyways, wanted to clarify a little 😅 I do think there's a good point where Astro is content-focused and it may good to have this automatic behaviour ootb. |
There was a problem hiding this comment.
Thanks @bluwy ! Left some comments and a question because I'm not sure whether MDX is going to work exactly the same, or slightly differently. (Since with MDX, there are two different ways to "use a layout" vs only the one way for Markdown pages.)
Changes
charset=utf-8will no longer be added toContent-Typein markdown and mdx pages. This matches the behaviour of other pages, e.g. astro or html pages.This PR
This PR adds
<meta charset="utf-8">automatically to all md/mdx pages if they have no layout. This allows users to type non-ASCII characters without setting up a layout to add the meta tag into the head.Would like your thoughts
A revelation I had (which is very obvious in hindsight) is that you could easily add
<meta charset="utf-8" />to the.mdor.mdxpages yourself directly. They accept HTML anyways and you don't really need a layout to put the meta tag in the head to work. So this whole PR felt causing more hidden magic?Do you think it's worth having the behaviour described in the
This PRsection above? Or simply remove it so that users should add the meta tag themselves?Testing
We have existing tests that covers this behaviour.
Docs
withastro/docs#9757
Is somewhat a breaking change which will be documented in the migration guide later. We may also want to add a
charsetnote in https://docs.astro.build/en/basics/layouts/#markdown-layouts.