-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sitemap): add missing xslURL
property to SitemapOptions
type
#12156
Conversation
🦋 Changeset detectedLatest commit: a40c386 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also seems like we're missing canonicalURL
here. Maybe we can add it together. And canonicalURL
also doesn't seem documented in the docs, which we probably also should 🥲
I'm also fine doing those later if preffered so approving the PR.
@bluwy Sure! Let me turn this PR into a draft for now. I'll add more commits later on. |
I found this PR: #3677 Integration Docs Next Steps It seems that the |
Oh interesting. Maybe @bholmesdev knows about this one. Anyways seems like it's another can of worms, and I'm fine with merging this PR for now 😅 |
Changes
xslURL
property toSitemapOptions
typexslURL
option not declared inSitemapOptions
type #12153Testing
Docs