Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sitemap): add missing xslURL property to SitemapOptions type #12156

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

mingjunlu
Copy link
Contributor

Changes

Testing

Docs

  • N/A

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: a40c386

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 8, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems like we're missing canonicalURL here. Maybe we can add it together. And canonicalURL also doesn't seem documented in the docs, which we probably also should 🥲

I'm also fine doing those later if preffered so approving the PR.

@mingjunlu
Copy link
Contributor Author

It also seems like we're missing canonicalURL here. Maybe we can add it together. And canonicalURL also doesn't seem documented in the docs, which we probably also should 🥲

I'm also fine doing those later if preffered so approving the PR.

@bluwy Sure! Let me turn this PR into a draft for now. I'll add more commits later on.

@mingjunlu mingjunlu marked this pull request as draft October 9, 2024 13:11
@mingjunlu
Copy link
Contributor Author

I found this PR: #3677 Integration Docs Next Steps

It seems that the canonicalURL option was removed intentionally. Does anyone remember the context?

@bluwy
Copy link
Member

bluwy commented Oct 14, 2024

Oh interesting. Maybe @bholmesdev knows about this one. Anyways seems like it's another can of worms, and I'm fine with merging this PR for now 😅

@mingjunlu mingjunlu marked this pull request as ready for review October 14, 2024 03:46
@bluwy bluwy merged commit 07754f5 into main Oct 14, 2024
13 checks passed
@bluwy bluwy deleted the fix/sitemap-options-type branch October 14, 2024 12:45
@astrobot-houston astrobot-houston mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sitemap] xslURL option not declared in SitemapOptions type
3 participants