Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't set statusMessage in HTTP/2 #12147

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: don't set statusMessage in HTTP/2 #12147

merged 1 commit into from
Oct 7, 2024

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Oct 7, 2024

Changes

#12105 added support for setting the response statusMessage. However this is not supported by HTTP/2, so a warning was being logged. This PR first checks that the response is not HTTP/2 before setting it.

Fixes #12134

Testing

Tested manually with astro-dev-http2 fixture

Docs

Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: 5007cc9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 7, 2024
@ascorbic ascorbic merged commit 9db755a into main Oct 7, 2024
13 checks passed
@ascorbic ascorbic deleted the h2-no-status branch October 7, 2024 14:27
@astrobot-houston astrobot-houston mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚨 [BUG] UnsupportedWarning: Status message is not supported by HTTP/2 (RFC7540 8.1.2.4)
3 participants