-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move lint rules to Biome #12145
Conversation
|
console.log(`[${fixture}] Generated posts`); | ||
console.info(`[${fixture}] Generated posts`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the rename from console.log
to console.info
intentional? Seems to have changed for many other code too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of these logs had suppression comments (many), this means those logs were intentional. console.log
are usually for debugging purposes, but console.info
are usually on purpose.
I deduced that all those logs were actually intentional, which means it makes more sense to turn them into .info
.
What do you think? Does it make sense? Do you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me. I also noticed the PR doesn't really change to .info
a lot, only for this performance/
directory which we don't use much either. So I think this is fine by me.
Changes
This PR turns off some eslint rules, and turns on the relative Biome rules.
The
noUnsedVariables
rule reports information diagnostics, so it should not bother too much. I run its respective code action (unsafe), which renamed all unused variables with an underscore e.g.el
->_el
.The
no-console
rule from eslint was incorrectly configured, because I ended removing a lot of suppression comments.I also moved the configuration file to
JSONC
, so I could move the comments we had in the eslint configuration file.Testing
Current CI should work
Docs
N/A