Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move lint rules to Biome #12145

Merged
merged 6 commits into from
Oct 8, 2024
Merged

chore: move lint rules to Biome #12145

merged 6 commits into from
Oct 8, 2024

Conversation

ematipico
Copy link
Member

Changes

This PR turns off some eslint rules, and turns on the relative Biome rules.

The noUnsedVariables rule reports information diagnostics, so it should not bother too much. I run its respective code action (unsafe), which renamed all unused variables with an underscore e.g. el -> _el.

The no-console rule from eslint was incorrectly configured, because I ended removing a lot of suppression comments.

I also moved the configuration file to JSONC, so I could move the comments we had in the eslint configuration file.

Testing

Current CI should work

Docs

N/A

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 9664125

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ematipico ematipico changed the title chore: move lint rules to Astro chore: move lint rules to Biome Oct 7, 2024
@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Oct 7, 2024
Comment on lines -28 to +26
console.log(`[${fixture}] Generated posts`);
console.info(`[${fixture}] Generated posts`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the rename from console.log to console.info intentional? Seems to have changed for many other code too.

Copy link
Member Author

@ematipico ematipico Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of these logs had suppression comments (many), this means those logs were intentional. console.log are usually for debugging purposes, but console.info are usually on purpose.

I deduced that all those logs were actually intentional, which means it makes more sense to turn them into .info.

What do you think? Does it make sense? Do you agree?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me. I also noticed the PR doesn't really change to .info a lot, only for this performance/ directory which we don't use much either. So I think this is fine by me.

@ematipico ematipico merged commit 2a1536d into main Oct 8, 2024
14 checks passed
@ematipico ematipico deleted the chore/move-rules-to-biome branch October 8, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants