Use IE conditional comment placeholders for server island start markers #12090
Conversation
🦋 Changeset detectedLatest commit: 5de434f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
markjaquith
force-pushed
the
issue/11995/server-island-placeholder-comment
branch
from
660fd38
to
079d3a4
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -47,7 +47,7 @@ export function renderServerIsland( | |||
| } | |||
| } | |||
|
|
|||
| destination.write('<!--server-island-start-->'); | |||
There was a problem hiding this comment.
astro here isn't anything special... it just needs to be a condition that evaluates to false. I wasn't sure about putting server-island-start in the condition part, because I was worried the dashes might break the regex minification libraries rely on to identify these conditional comments. As a bonus, it identifies "hey, Astro put this weird comment here" to anyone who might happen to see it and wonder. But this could be if false or if serverislandstart just as easily.
These placeholders are much less likely to be removed by HTML minifiers, because they have traditionally been used to change the behavior of site.
markjaquith
force-pushed
the
issue/11995/server-island-placeholder-comment
branch
from
b58e9c8
to
5de434f
Compare
|
I changed this from a |
|
The changeset here should be patch anyway, as the feature it updates is experimental on this branch. |
There was a problem hiding this comment.
I can't believe the fix is this simple 😅 Thanks so much @markjaquith
Changes
fixes #11995
cc: @matthewp — we talked about this on Twitter.
Swaps the generic HTML comment placeholders with IE conditional comments. These placeholders have existed for a long time, and are much less likely to be removed by HTML minifiers, because they have traditionally been used to change the behavior of a site.
A similar fix was implemented in Livewire to work around Cloudflare HTML minification removing the HTML comment placeholders Livewire was inserting for a similar purpose.
Testing
No tests changed, since it's just changing the content of an HTML comment. I haven't been able to set up the original commenter's complete environment for a complete fix verification, but I did look at the source code for the minifier library they were using, and that library has code to not remove IE conditional comments.
Docs
No documentation needed... the feature should just work more reliably now when Astro output is touched by HTML minifiers.