Fix build.client and build.server resolve behaviour
#11916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e0e65e1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Princesseuh
approved these changes
Sep 4, 2024
florian-lefebvre
approved these changes
Sep 5, 2024
Co-authored-by: Florian Lefebvre <[email protected]>
The previous one was correct because we started the paragraph with an example
sarah11918
approved these changes
Sep 9, 2024
Co-authored-by: Sarah Rainsberger <[email protected]>
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensure that
build.clientandbuild.serverwill actually resolve relative to theoutDiras currently documented. The changesets have extra information of the previous behaviour.Testing
Existing tests should pass. I also remove the previously set
build.clientandbuild.serveroptions as the workaround is no longer needed.Docs
Added changesets explaining the breaking change.