Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export LoaderContext types #11914

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Export LoaderContext types #11914

merged 3 commits into from
Sep 4, 2024

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Sep 3, 2024

Changes

The LoaderContext object that is passed to custom loaders is exported as a public type, but previously the individual properties used types that weren't public. This PR exports those types. It also changes the confusingly-named ScopedDataStore to DataStore to reflect the fact that it's the only public data store type.

Testing

Docs

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: 6cd2284

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 3, 2024
@ascorbic ascorbic requested a review from bluwy September 3, 2024 16:43
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ascorbic ascorbic merged commit b5d827b into next Sep 4, 2024
13 checks passed
@ascorbic ascorbic deleted the cl-public-types branch September 4, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants