-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cannot read properties of null (reading 'Symbol(astro.headAndContent)') #11839
Conversation
🦋 Changeset detectedLatest commit: f9ac66d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think it would be best if you can figure out how this happens in the first place. A repro or test would help us prevent regressing this in the future. |
@bluwy I found the issue and added a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great test!
Hey! I have this same issue in prod, could we get this merged faster? |
@bluwy can you take a look at this now that you've changed how the test work? |
LGTM. We had an internal discussion whether this behaviour is desirable as we've not documented returning Given that I think handling |
Changes
Testing
Can not provide a minimal reproduction example.
Docs
Docs don't need change.