fix(create-astro): log fetch errors #11567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8351343 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: create-astro
|
Any chance you could take a screenshot of what it looks like now vs before? |
|
Sure! Before: |
|
Awesome, thank you! It is a little bit wonky looking, but it's fine with me since there's really a limited amount of errors you can get here. |
Princesseuh
approved these changes
Jul 29, 2024
|
From what I can see we don't have any structured errors in create-astro, so logs like that are the best we have |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If create-astro fails when downloading a template, it currently only logs something unhelpful like "fetch error". This leads to reports like #11396, which is probably mutliple different issues. This PR changes it to traverse into
err.causeto find the underlying error from undici.Fixes #11396
Testing
Tested by disabling the network after starting the command, which gave "Error: getaddrinfo ENOTFOUND api.github.com"
Docs