Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix attribute rendering for boolean values (#11369)" #11408

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Revert "Fix attribute rendering for boolean values (#11369)" #11408

merged 2 commits into from
Jul 3, 2024

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jul 3, 2024

This reverts commit e6de11f.

Changes

  • This was discovered to break Starlight.
  • We should probably wait on 5.0 for this.

Testing

N/A

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: de201e8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Jul 3, 2024
delucis
delucis approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewp!

@matthewp matthewp merged commit b9e906f into main Jul 3, 2024
13 checks passed
@matthewp matthewp deleted the revert-bool-attr branch July 3, 2024 21:44
@astrobot-houston astrobot-houston mentioned this pull request Jul 3, 2024
Merged
ematipico pushed a commit that referenced this pull request Jul 18, 2024
@matthewp @ematipico
Revert "Fix attribute rendering for boolean values (#11369)" (#11408)
42b2216 
* Revert "Fix attribute rendering for boolean values (#11369)"

This reverts commit e6de11f.

* Add a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @delucis