fix(astro): positioning of inspection tooltip in RTL mode #11081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c09ca1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
approved these changes
May 17, 2024
There was a problem hiding this comment.
Looks great to me. I think another way to test it is doing something like:
astro/packages/astro/e2e/dev-toolbar.test.js
Lines 220 to 226 in 4d32a80
But the current one is also fine by me.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In RTL mode (
<body dir="rtl">the inspection tooltip tend to overflow on the left side of the page.This pull request contains a fix for that, which will make sure the tooltip stays in the viewport.
Before:
Nagranie.z.ekranu.2024-05-17.o.09.15.52.mov
After:
Nagranie.z.ekranu.2024-05-17.o.09.16.16.mov
Closes #11044
Testing
Playwright test was added to make sure the tooltip stays in the viewport in all edge-cases (corners).
Note: There is one thing I am not fully satisfied with. I couldn't use visibility ratio of
1(fully visible), because for some reason elements positioned absolutely overflow plus scrollbar is being displayed without reason. If anyone has an idea how to prevent that, please share it 🙏Docs
No update needed.