Update sharp to 0.33 to fix issue with Alpine Linux #10684

PeterDraex · 2024-04-04T20:56:29Z

Changes

This PR updates the version of the sharp dependency to ^0.33 and thus makes Astro compatible with Alpine Linux containers.

It was impossible for me to use the Astro image service in an Alpine Linux docker container. Even though I would install sharp 0.33.3 in my app, pnpm would download version 0.32.6, which doesn't work in Alpine Linux container. I have to override the downloaded version in my package.json.

For more details about the issue see:

Testing

Automatic tests
Override of sharp with the current version in local project

Docs

This resolves existing bug. No documentation needed.

It was impossible for me to use the Astro image service in an Alpine Linux docker container. Even though I would install sharp `0.33.3` in my app, pnpm would download version `0.32.6`, which doesn't work in Alpine Linux container. Currently, I have to override the downloaded version in my package.json. For more details see: - lovell/sharp#4054 - https://discord.com/channels/830184174198718474/1224861729792458803/1224861729792458803 This PR updates the version of the `sharp` dependency to `^0.33` and thus makes Astro compatible with Alpine Linux.

changeset-bot · 2024-04-04T20:56:33Z

🦋 Changeset detected

Latest commit: be1979b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Princesseuh

Blocking this because it's a breaking change. Sharp's 0.33.0 engines contract is stricter than Astro's, requiring a higher version of Node 18 and 20 than Astro, and not supporting Node 19 at all.

As such, for a certain percentage of users, Sharp would just not get installed ever unless they forced the install. Last time we updated to 0.33.0 (because I didn't know its checks were stricter than us, ha), we ended up with a bunch of support threads from people running outdated versions of Node.

Now that we upgraded our Node contract in 4.6.0, we can do this

packages/astro/package.json

Princesseuh

Thank you, this looks great!

pnpm-lock.yaml

sarah11918

Thanks for this helpful contribution @PeterDraex ! I've just updated the changeset message to be a tiny bit more explicit. Especially since this is being released with a minor version of Astro, we try to give the changesets a little extra love and attention as people are checking more closely! 🙌

.changeset/famous-mugs-grab.md

matthewp · 2024-04-23T14:31:46Z

@PeterDraex would you mind rebasing with main and rerunning install to update the lockfile?

…hastro#10692)

…ithastro#10693) * Add disableremoteplayback attribute to VideoHTMLAttributes interface * Move disableremoteplayback from VideoHTMLAttributes to MediaHTMLAttributes * Create olive-camels-greet.md * Update packages/astro/astro-jsx.d.ts --------- Co-authored-by: Erika <[email protected]>

…withastro#10694) * test(@astrojs/node) wait for server listening in trailing-slash tests * fix missing waitServerListen * fix import statement --------- Co-authored-by: Emanuele Stoppa <[email protected]>

…and `build:ci:no-cache` to skip caching for build as well (withastro#10696) * chore: add test:citgm command that would run tests without caching * adding build ci with no cache

* fix(withastro#10399, PLT-1786): improve notification contrast on hover * chore: add changeset

Co-authored-by: Emanuele Stoppa <[email protected]>

…o#10754) Co-authored-by: Oliver Speir <[email protected]>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* db: export 'alias' from drizzle-orm/sqlite-core * chore: changeset * fix: changeset target --------- Co-authored-by: Ben Holmes <[email protected]>

* chore: configuration * chore: update main commands * chore: revert formatting package.json * chore: rebase

…us during view transition navigation. (withastro#10799) * Fixes an issue with persisted non-text input fields that have the focus during view transition navigation. * better check

* add tests that reveal issue * fix trailing slash root page issue * add changeset

…ithastro#10773) * optimization(runtime): create smaller objects for each Astro global * add changeset * Make slots lazy --------- Co-authored-by: bluwy <[email protected]>

…ro#10763) * Invalidate CC cache manifest when lockfile or config changes * Close the handle and increment manifest version * debug info * Provide a reason for cache busting * Handle compile metadata missing * Try it this way * Copy over cached assets as well * Only restore chunks when cache is valid * Better handle invalid caches * Explain when there is no content manifest * Add tests * debugging * Remove debugging * Update packages/astro/src/core/build/plugins/plugin-content.ts Co-authored-by: Bjorn Lu <[email protected]> * Update packages/astro/src/core/build/plugins/plugin-content.ts Co-authored-by: Bjorn Lu <[email protected]> * Review comments * Add chunks path constant --------- Co-authored-by: Bjorn Lu <[email protected]>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…e blog starter template (withastro#10814) Currently the 4th point on home page says: "Check out the included blog posts in src/pages/blog/". It the path here should be "src/content/blog/".

…tch-1

PeterDraex · 2024-04-23T17:17:45Z

@PeterDraex would you mind rebasing with main and rerunning install to update the lockfile?

@matthewp Done. I've also updated sharp version in examples/starlog/package.json. Is that okay?

matthewp · 2024-04-24T14:20:03Z

Yes, thank you!

github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 4, 2024

PeterDraex added 2 commits April 4, 2024 18:37

update lock file

c09b91e

add changelog

f1a9132

PeterDraex marked this pull request as ready for review April 4, 2024 21:42

Princesseuh previously requested changes Apr 4, 2024

View reviewed changes

Princesseuh added this to the 4.7.0 milestone Apr 19, 2024

Merge branch 'main' into patch-1

7002019

Princesseuh reviewed Apr 19, 2024

View reviewed changes

packages/astro/package.json Outdated Show resolved Hide resolved

Update packages/astro/package.json

1a6a670

Princesseuh approved these changes Apr 19, 2024

View reviewed changes

Princesseuh reviewed Apr 19, 2024

View reviewed changes

pnpm-lock.yaml Outdated Show resolved Hide resolved

Update pnpm-lock.yaml

16a9433

ematipico approved these changes Apr 19, 2024

View reviewed changes

sarah11918 reviewed Apr 22, 2024

View reviewed changes

.changeset/famous-mugs-grab.md Show resolved Hide resolved

ematipico and others added 12 commits April 23, 2024 12:02

ci: update check-merge.yml action (withastro#10690)

587d0c2

test(@astrojs/node) listen for server setup errors in test-utils (wit…

a2428eb

…hastro#10692)

test(@astrojs/node) wait for server listening in trailing-slash tests (…

2ee640a

…withastro#10694) * test(@astrojs/node) wait for server listening in trailing-slash tests * fix missing waitServerListen * fix import statement --------- Co-authored-by: Emanuele Stoppa <[email protected]>

chore: add test:citgm command that would run tests without caching …

087c523

…and `build:ci:no-cache` to skip caching for build as well (withastro#10696) * chore: add test:citgm command that would run tests without caching * adding build ci with no cache

chore: fix build:ci:no-cache test:citgm (withastro#10698)

ef37d88

Improve dev toolbar notification contrast on hover (withastro#10657)

3969364

* fix(withastro#10399, PLT-1786): improve notification contrast on hover * chore: add changeset

fix test:citgm --force flag not passed correctly (withastro#10706)

16f0822

Skip prerender chunk in static output (withastro#10695)

436acee

Remove unused config in Vue JSX integration (withastro#10687)

6cb3eef

Refactor MDX transformJSX handling (withastro#10688)

85ea333

Fix vue-jsx change (withastro#10716)

29a7053

bluwy and others added 24 commits April 23, 2024 12:02

Improve sitemap generate performance (withastro#10795)

b0aba11

Disable streaming for SSG (withastro#10796)

26ca2fd

fix: use assetsDir in creating vite config (withastro#10732)

26e0262

Co-authored-by: Emanuele Stoppa <[email protected]>

fix: MDX cannot find relative image path without leading ./ (withastr…

f174cdf

…o#10754) Co-authored-by: Oliver Speir <[email protected]>

[ci] release (withastro#10777)

e0124fe

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

db: export 'alias' from drizzle-orm/sqlite-core (withastro#10789)

635d65c

* db: export 'alias' from drizzle-orm/sqlite-core * chore: changeset * fix: changeset target --------- Co-authored-by: Ben Holmes <[email protected]>

chore: use Biome to format JS files (withastro#10788)

6c310f4

* chore: configuration * chore: update main commands * chore: revert formatting package.json * chore: rebase

[ci] format

d71a05d

Fixes an issue with persisted non-text input fields that have the foc…

7c70b98

…us during view transition navigation. (withastro#10799) * Fixes an issue with persisted non-text input fields that have the focus during view transition navigation. * better check

[ci] format

58c345d

test: fix regression upon import sorting (withastro#10802)

88e2451

fix(sitemap): Trailing slashes on root url (withastro#10772)

6ba89e4

* add tests that reveal issue * fix trailing slash root page issue * add changeset

[ci] format

9879f22

optimization(runtime): create smaller objects for each Astro global (w…

d515a74

…ithastro#10773) * optimization(runtime): create smaller objects for each Astro global * add changeset * Make slots lazy --------- Co-authored-by: bluwy <[email protected]>

add/cli: update list of integrations (withastro#10811)

336c5c6

[ci] format

386d960

[ci] release (withastro#10798)

4f58aeb

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

fixed the path to checkout existing blog posts on the home page of th…

542d07f

…e blog starter template (withastro#10814) Currently the 4th point on home page says: "Check out the included blog posts in src/pages/blog/". It the path here should be "src/content/blog/".

Update packages/astro/package.json

b5f7e75

Update pnpm-lock.yaml

bb7fc4f

Merge branch 'patch-1' of https://github.com/PeterDraex/astro into pa…

6a5b418

…tch-1

Merge remote-tracking branch 'origin/main' into patch-1

bba254d

update sharp version in examples/starlog and update pnpm-lock.yaml

a231779

github-actions bot added the pkg: example Related to an example package (scope) label Apr 23, 2024

Merge branch 'main' into patch-1

be1979b

matthewp merged commit 8b59d5d into withastro:main Apr 24, 2024
14 checks passed

astrobot-houston mentioned this pull request Apr 24, 2024

[ci] release #10865

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update sharp to 0.33 to fix issue with Alpine Linux #10684

Update sharp to 0.33 to fix issue with Alpine Linux #10684

PeterDraex commented Apr 4, 2024 •

edited

Loading

changeset-bot bot commented Apr 4, 2024 •

edited

Loading

Princesseuh left a comment

Princesseuh left a comment

sarah11918 left a comment

matthewp commented Apr 23, 2024

PeterDraex commented Apr 23, 2024

matthewp commented Apr 24, 2024

Update sharp to 0.33 to fix issue with Alpine Linux #10684

Update sharp to 0.33 to fix issue with Alpine Linux #10684

Conversation

PeterDraex commented Apr 4, 2024 • edited Loading

Changes

Testing

Docs

changeset-bot bot commented Apr 4, 2024 • edited Loading

🦋 Changeset detected

Princesseuh left a comment

Choose a reason for hiding this comment

Princesseuh left a comment

Choose a reason for hiding this comment

sarah11918 left a comment

Choose a reason for hiding this comment

matthewp commented Apr 23, 2024

PeterDraex commented Apr 23, 2024

matthewp commented Apr 24, 2024

PeterDraex commented Apr 4, 2024 •

edited

Loading

changeset-bot bot commented Apr 4, 2024 •

edited

Loading