Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building static sites with Astro DB #10655

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Fix building static sites with Astro DB #10655

merged 3 commits into from
Apr 2, 2024

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Apr 2, 2024

Changes

  • When building a site with output: 'static' (or hybrid), the temporary app token is needed to build pages.
  • Pass through in this condition so this is used if the env doesn't exist (which won't most of the time).

Testing

  • New test fixture added.

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 30bc438

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for stattacking this bug quickly!

@matthewp matthewp merged commit b1eda3d into main Apr 2, 2024
14 checks passed
@matthewp matthewp deleted the build-remote-static branch April 2, 2024 20:07
@astrobot-houston astrobot-houston mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants